Re: [PATCH] x86/boot: add prototype for __fortify_panic()

From: Jeff Johnson
Date: Thu May 30 2024 - 12:24:20 EST


On 5/30/2024 8:42 AM, Nikolay Borisov wrote:
>
>
> On 29.05.24 г. 21:09 ч., Jeff Johnson wrote:
>> As discussed in [1] add a prototype for __fortify_panic() to fix the
>> 'make W=1 C=1' warning:
>>
>> arch/x86/boot/compressed/misc.c:535:6: warning: symbol '__fortify_panic' was not declared. Should it be static?
>
> Actually doesn't it make sense to have this defined under ../string.h ?
> Actually given that we don't have any string fortification under the
> boot/ why have the fortify _* functions at all ?

I'll let Kees answer these questions since I just took guidance from him :)

/jeff