Re: [PATCH] tick/nohz_full: don't abuse smp_call_function_single() in tick_setup_device()

From: Oleg Nesterov
Date: Thu May 30 2024 - 13:01:34 EST


On 05/30, Frederic Weisbecker wrote:
>
> Looks good, but can we have a WARN_ONCE(tick_do_timer_cpu != tick_do_timer_boot_cpu)
> right before that, just to make sure our assumptions above are right forever and
> the boot CPU hasn't stopped the tick up to that point?

Sure, I thought about the additional sanity checks too. Although I had something
different in mind.

Frederic, et al, I am on private trip again without my working laptop, can't read
the code. I'll reply on Saturday, OK?

Thanks for review!

Oleg.