Re: [net-next PATCH] octeontx2: Improve mailbox tracepoints for debugging

From: kernel test robot
Date: Thu May 30 2024 - 16:51:51 EST


Hi Subbaraya,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url: https://github.com/intel-lab-lkp/linux/commits/Subbaraya-Sundeep/octeontx2-Improve-mailbox-tracepoints-for-debugging/20240530-195537
base: net-next/main
patch link: https://lore.kernel.org/r/1717070038-18381-1-git-send-email-sbhatta%40marvell.com
patch subject: [net-next PATCH] octeontx2: Improve mailbox tracepoints for debugging
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20240531/202405310425.kxMtnCmV-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405310425.kxMtnCmV-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405310425.kxMtnCmV-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

In file included from include/trace/trace_events.h:419,
from include/trace/define_trace.h:102,
from drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h:144,
from drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c:9:
>> drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:119:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
119 | );
| ^~
In file included from include/trace/trace_events.h:375:
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h: In function 'trace_event_raw_event_otx2_msg_wait_rsp':
>> drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:115:28: error: '__assign_str' undeclared (first use in this function)
115 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~
include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
402 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:110:1: note: in expansion of macro 'TRACE_EVENT'
110 | TRACE_EVENT(otx2_msg_wait_rsp,
| ^~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:115:13: note: in expansion of macro 'TP_fast_assign'
115 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:115:28: note: each undeclared identifier is reported only once for each function it appears in
115 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~
include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
402 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:110:1: note: in expansion of macro 'TRACE_EVENT'
110 | TRACE_EVENT(otx2_msg_wait_rsp,
| ^~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:115:13: note: in expansion of macro 'TP_fast_assign'
115 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h: At top level:
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:134:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
134 | );
| ^~
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:134:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
134 | );
| ^~
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h: In function 'trace_event_raw_event_otx2_msg_status':
>> drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:128:28: error: unknown type name '__assign_str'
128 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~
include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
402 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:121:1: note: in expansion of macro 'TRACE_EVENT'
121 | TRACE_EVENT(otx2_msg_status,
| ^~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:128:13: note: in expansion of macro 'TP_fast_assign'
128 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~~~
>> include/trace/stages/stage6_event_callback.h:9:17: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'entry'
9 | #define __entry entry
| ^~~~~
include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
402 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:121:1: note: in expansion of macro 'TRACE_EVENT'
121 | TRACE_EVENT(otx2_msg_status,
| ^~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:128:13: note: in expansion of macro 'TP_fast_assign'
128 | TP_fast_assign(__assign_str(dev, pci_name(pdev))
| ^~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:130:28: note: in expansion of macro '__entry'
130 | __entry->num_msgs = num_msgs;
| ^~~~~~~
In file included from include/trace/trace_events.h:469:
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h: At top level:
>> drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:119:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
119 | );
| ^~
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:134:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
134 | );
| ^~
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|
drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h:134:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
134 | );
| ^~
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|


vim +/__assign_str +119 drivers/net/ethernet/marvell/octeontx2/af/./rvu_trace.h

109
110 TRACE_EVENT(otx2_msg_wait_rsp,
111 TP_PROTO(const struct pci_dev *pdev),
112 TP_ARGS(pdev),
113 TP_STRUCT__entry(__string(dev, pci_name(pdev))
114 ),
> 115 TP_fast_assign(__assign_str(dev, pci_name(pdev))
116 ),
117 TP_printk("[%s] timed out while waiting for response\n",
118 __get_str(dev))
> 119 );
120
121 TRACE_EVENT(otx2_msg_status,
122 TP_PROTO(const struct pci_dev *pdev, const char *msg, u16 num_msgs),
123 TP_ARGS(pdev, msg, num_msgs),
124 TP_STRUCT__entry(__string(dev, pci_name(pdev))
125 __string(str, msg)
126 __field(u16, num_msgs)
127 ),
> 128 TP_fast_assign(__assign_str(dev, pci_name(pdev))
129 __assign_str(str, msg)
130 __entry->num_msgs = num_msgs;
131 ),
132 TP_printk("[%s] %s num_msgs:%d\n", __get_str(dev),
133 __get_str(str), __entry->num_msgs)
> 134 );
135

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki