Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)

From: Shuah Khan
Date: Thu May 30 2024 - 17:14:49 EST


On 5/30/24 13:13, John Hubbard wrote:
On 5/30/24 12:03 PM, Shuah Khan wrote:
On 5/28/24 20:29, John Hubbard wrote:
The .PHONY targets "all" and "clean"  are both defined in the file that
is included in the very next line: ../lib.mk.


What problems are you seeing without this patch?

Code duplication. It's a sin. :)

Please mention that you are removing duplicate code.

futex Makefile overrides CLEAN - just making sure it
does the cleanup correctly.

thanks,
-- Shuah