Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver
From: Dmitry Baryshkov
Date: Thu May 30 2024 - 19:25:36 EST
On Fri, 31 May 2024 at 02:24, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Thu, May 30, 2024 at 4:13 PM Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxx> wrote:
> >
> > There are two ways to describe an eDP panel in device tree. The
> > recommended way is to add a device on the AUX bus, ideally using the
> > edp-panel compatible. The legacy way is to define a top-level platform
> > device for the panel.
> >
> > Document that adding support for eDP panels in a legacy way is strongly
> > discouraged (if not forbidden at all).
> >
> > While we are at it, also drop legacy compatible strings and bindings for
> > five panels. These compatible strings were never used by a DT file
> > present in Linux kernel and most likely were never used with the
> > upstream Linux kernel.
> >
> > The following compatibles were never used by the devices supported by
> > the upstream kernel and are a subject to possible removal:
> >
> > - lg,lp097qx1-spa1
> > - samsung,lsn122dl01-c01
> > - sharp,ld-d5116z01b
> >
> > I'm considering dropping them later, unless there is a good reason not
> > to do so.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > Changes in v3:
> > - Rephrased the warning comment, following some of Doug's suggestions.
> > - Link to v2: https://lore.kernel.org/r/20240529-edp-panel-drop-v2-0-fcfc457fc8dd@xxxxxxxxxx
> >
> > Changes in v2:
> > - Actually drop support for five panels acked by Doug Andersson
> > - Link to v1: https://lore.kernel.org/r/20240523-edp-panel-drop-v1-1-045d62511d09@xxxxxxxxxx
> >
> > ---
> > Dmitry Baryshkov (3):
> > drm/panel-edp: add fat warning against adding new panel compatibles
> > dt-bindings: display: panel-simple: drop several eDP panels
> > drm/panel-edp: drop several legacy panels
> >
> > .../bindings/display/panel/panel-simple.yaml | 10 --
> > drivers/gpu/drm/panel/panel-edp.c | 192 +++------------------
> > 2 files changed, 25 insertions(+), 177 deletions(-)
>
> Thanks! I'm happy to apply this series or also happy if some other
> drm-misc committer member wants to apply it. Probably we should wait
> for a DT person to make sure that they don't have any problems with
> the bindings change.
Yes, I'm waiting for an ack from DT maintainers.
--
With best wishes
Dmitry