RE: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() cleanups

[Peng Fan]

Hi Geert

> Subject: Re: [PATCH v2 00/20] pinctrl: Use scope based of_node_put()
> cleanups
> 
> Hi Peng,
> 
> On Sat, May 4, 2024 at 3:12 PM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> wrote:
> > Use scope based of_node_put() to simplify code. It reduces the chance
> > of forgetting of_node_put(), and also simplifies error handling path.
> > I not able to test the changes on all the hardwares, so driver owners,
> > please help review when you have time.
> >
> > This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c,
> > thanks.
> >
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> 
> Andy's question about code generation on a related patch made me wonder,
> too.
> 
> On arm32, a conversion to for_each_child_of_node_scoped() seems to cost ca.
> 48 bytes of additional code, regardless of whether there were explicit
> cleanups before or not.
> 
> I checked "pinctrl: renesas: Use scope based of_node_put() cleanups", and all
> but the conversions in *_dt_node_to_map() cost 48 bytes each.
> 

I am not sure this is an issue or else. What would you suggest me to do?
If you think extra 48bytes consumption is not good here, feel free to drop the
patch.

Thanks,
Peng.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds