Re: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h

From: kernel test robot
Date: Fri May 31 2024 - 02:44:14 EST


Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on shawnguo/for-next rockchip/for-next linus/master v6.10-rc1 next-20240529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ASoC-codecs-Remove-unused-of_gpio-h/20240531-070350
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20240530230037.1156253-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/6] ASoC: codecs: Remove unused of_gpio.h
config: i386-buildonly-randconfig-006-20240531 (https://download.01.org/0day-ci/archive/20240531/202405311428.tzsBMIPs-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405311428.tzsBMIPs-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405311428.tzsBMIPs-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> sound/soc/codecs/tas2781-comlib.c:408:6: error: call to undeclared function 'gpio_is_valid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
408 | if (gpio_is_valid(tas_priv->irq_info.irq_gpio))
| ^
sound/soc/codecs/tas2781-comlib.c:408:6: note: did you mean 'uuid_is_valid'?
include/linux/uuid.h:102:19: note: 'uuid_is_valid' declared here
102 | bool __must_check uuid_is_valid(const char *uuid);
| ^
>> sound/soc/codecs/tas2781-comlib.c:409:3: error: call to undeclared function 'gpio_free'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
409 | gpio_free(tas_priv->irq_info.irq_gpio);
| ^
sound/soc/codecs/tas2781-comlib.c:409:3: note: did you mean 'pmd_free'?
include/asm-generic/pgtable-nopmd.h:63:20: note: 'pmd_free' declared here
63 | static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd)
| ^
2 errors generated.
--
>> sound/soc/codecs/tas2781-i2c.c:664:6: error: call to undeclared function 'gpio_is_valid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
664 | if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) {
| ^
sound/soc/codecs/tas2781-i2c.c:664:6: note: did you mean 'uuid_is_valid'?
include/linux/uuid.h:102:19: note: 'uuid_is_valid' declared here
102 | bool __must_check uuid_is_valid(const char *uuid);
| ^
>> sound/soc/codecs/tas2781-i2c.c:665:8: error: call to undeclared function 'gpio_request'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
665 | rc = gpio_request(tas_priv->irq_info.irq_gpio,
| ^
>> sound/soc/codecs/tas2781-i2c.c:668:4: error: call to undeclared function 'gpio_direction_input'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
668 | gpio_direction_input(
| ^
sound/soc/codecs/tas2781-i2c.c:668:4: note: did you mean 'gpiod_direction_input'?
include/linux/gpio/consumer.h:110:5: note: 'gpiod_direction_input' declared here
110 | int gpiod_direction_input(struct gpio_desc *desc);
| ^
>> sound/soc/codecs/tas2781-i2c.c:672:5: error: call to undeclared function 'gpio_to_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
672 | gpio_to_irq(tas_priv->irq_info.irq_gpio);
| ^
sound/soc/codecs/tas2781-i2c.c:672:5: note: did you mean 'gpiod_to_irq'?
include/linux/gpio/consumer.h:167:5: note: 'gpiod_to_irq' declared here
167 | int gpiod_to_irq(const struct gpio_desc *desc);
| ^
4 errors generated.


vim +/gpio_is_valid +408 sound/soc/codecs/tas2781-comlib.c

ef3bcde75d06d6 Shenghao Ding 2023-06-18 405
ef3bcde75d06d6 Shenghao Ding 2023-06-18 406 void tasdevice_remove(struct tasdevice_priv *tas_priv)
ef3bcde75d06d6 Shenghao Ding 2023-06-18 407 {
ef3bcde75d06d6 Shenghao Ding 2023-06-18 @408 if (gpio_is_valid(tas_priv->irq_info.irq_gpio))
ef3bcde75d06d6 Shenghao Ding 2023-06-18 @409 gpio_free(tas_priv->irq_info.irq_gpio);
ef3bcde75d06d6 Shenghao Ding 2023-06-18 410 mutex_destroy(&tas_priv->codec_lock);
ef3bcde75d06d6 Shenghao Ding 2023-06-18 411 }
ef3bcde75d06d6 Shenghao Ding 2023-06-18 412 EXPORT_SYMBOL_GPL(tasdevice_remove);
ef3bcde75d06d6 Shenghao Ding 2023-06-18 413

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki