Re: [PATCH v2] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE condition

[Sebastian Fricke]

Hey Nas,

just before you send out V3 ...

On 28.05.2024 11:04, Nas Chung wrote:
> Explicitly compare a buffer type only with valid buffer types,
> to avoid matching the buffer type outside of valid buffer
> type set.

s/matching the buffer type outside of valid buffer type set/
  matching a buffer type outside of the valid buffer type set/

Regards,
Sebastian

> Signed-off-by: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
> ---
> include/uapi/linux/videodev2.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index fe6b67e83751..fa2b7086e480 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -157,6 +157,10 @@ enum v4l2_buf_type {
> 	V4L2_BUF_TYPE_PRIVATE              = 0x80,
> };
>
> +#define V4L2_TYPE_IS_VALID(type)		\
> +	((type) >= V4L2_BUF_TYPE_VIDEO_CAPTURE	\
> +	 && (type) <= V4L2_BUF_TYPE_META_OUTPUT)
> +
> #define V4L2_TYPE_IS_MULTIPLANAR(type)			\
> 	((type) == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE	\
> 	 || (type) == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> @@ -171,7 +175,8 @@ enum v4l2_buf_type {
> 	 || (type) == V4L2_BUF_TYPE_SDR_OUTPUT			\
> 	 || (type) == V4L2_BUF_TYPE_META_OUTPUT)
>
> -#define V4L2_TYPE_IS_CAPTURE(type) (!V4L2_TYPE_IS_OUTPUT(type))
> +#define V4L2_TYPE_IS_CAPTURE(type)	\
> +	(V4L2_TYPE_IS_VALID(type) && !V4L2_TYPE_IS_OUTPUT(type))
>
> enum v4l2_tuner_type {
> 	V4L2_TUNER_RADIO	     = 1,
> --
> 2.25.1