Re: [PATCH v3 0/2] iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver
From: Krzysztof Kozlowski
Date: Fri May 31 2024 - 03:52:21 EST
On 29/05/2024 06:57, Yasin Lee wrote:
> From: Yasin Lee <yasin.lee.x@xxxxxxxxx>
>
> v3:
> - Renamed the files to keep the file names consistent with the chip name.
> - Removed custom bit operation macro definitions.
> - Deleted redundant documentation that duplicated the Standard ABI.
> - Deleted unused header files.
> - Deleted unused register definitions.
> - Changed parts of the code related to circuit design to be configurable through DTS.
> - Removed unnecessary print statements.
> - Fixed the error in hx9031as_write_event_val.
> - Removed unnecessary threshold settings in the probe.
> - Replaced enable_irq(data->client->irq) with interrupt enable register operations.
> - Fixed style issues.
Please do not ignore comments but respond to them. Go back to 15th of
May and acknowledge all of them. You repeated every single issue...
Best regards,
Krzysztof