Re: [PATCH v2] dt-bindings: dma: fsl,imx-dma: Convert to dtschema

[Krzysztof Kozlowski]

On 31/05/2024 11:04, Animesh Agarwal wrote:
> Convert the fsl i.MX DMA controller bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
> ---
>  .../devicetree/bindings/dma/fsl,imx-dma.yaml  | 56 +++++++++++++++++++

Thank you for your patch. There is something to discuss/improve.


> +  "#dma-cells":
> +    const: 1
> +
> +  dma-channels:
> +    maximum: 16

maximum or const?

deprecated: true

> +
> +  dma-requests:
> +    description: Number of DMA requests supported.

deprecated: true

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#dma-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dma-controller@10001000 {
> +      compatible = "fsl,imx27-dma";
> +      reg = <0x10001000 0x1000>;
> +      interrupts = <32 33>;
> +      #dma-cells = <1>;
> +      dma-channels = <16>;

and drop it from here

Best regards,
Krzysztof