Re: [RFC PATCH v4 3/8] iomap: pass blocksize to iomap_truncate_page()

From: Christoph Hellwig
Date: Fri May 31 2024 - 08:41:05 EST


> - const struct iomap_ops *ops)
> +iomap_truncate_page(struct inode *inode, loff_t pos, unsigned int blocksize,
> + bool *did_zero, const struct iomap_ops *ops)
> {
> - unsigned int blocksize = i_blocksize(inode);
> - unsigned int off = pos & (blocksize - 1);
> + unsigned int off = rem_u64(pos, blocksize);
>
> /* Block boundary? Nothing to do */
> if (!off)

Instad of passing yet another argument here, can we just kill
iomap_truncate_page?

I.e. just open code the rem_u64 and 0 offset check in the only caller
and call iomap_zero_range. Same for the DAX variant and it's two
callers.