Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors

[Guenter Roeck]

Hi René,

On 5/31/24 03:01, René Rebe wrote:
> Hi,
>
> On May 31, 2024, at 11:31, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Hi all,
> >
> > > > Wolfgang seems to think it's important:
> >
> > Wolfram, please.
> >
> > > > https://lore.kernel.org/lkml/tdia472d4pow2osabef24y2ujkkquplfajxmmtk5pnxllsdxsz@wxzynz7llasr/
> > >
> > > Ok, but that doesn't explain the reason. Wolfram, Paul, why do you
> > > think this is needed ? Note that I am not opposed to adding spd
> > > eeprom support, but I'd like to know why I am doing it before
> > > I spend time on it.
> >
> > A working eeprom driver is needed to get 'decode-dimms' from the
> > i2c-tools package working. Jean reported that EEPROM access for DDR5 is
> > different from DDR4, so it needs a separate driver. And
> > i2c_register_spd() then needs to be updated to use the new driver for
> > DDR5.
>
> Well my original downstream driver already had eeprom access:
>
> 	https://svn.exactcode.de/t2/trunk/package/kernel/linux/spd-5118.patch

Yes, but you didn't send it upstream, so I took it, fixed a couple of bugs,
dropped eeprom support since that is secondary for my use case as well as the
out-of-tree parity code, and submitted it. I'd be more than happy to let you
take over if you like.

Thanks,
Guenter