Re: [PATCH v3 1/1] dt-bindings: iio: adc: add a7779 doc

From: Krzysztof Kozlowski
Date: Fri May 31 2024 - 11:25:45 EST


On 31/05/2024 15:35, Ramona Alexandra Nechita wrote:
> Add dt bindings for adc ad7779.
>
> Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@xxxxxxxxxx>
> ---
> .../ABI/testing/sysfs-bus-iio-adc-ad777x | 23 +++++
> .../bindings/iio/adc/adi,ad7779.yaml | 87 +++++++++++++++++++
> 2 files changed, 110 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7779.yaml

Why is this sent separately troubles us all... I saw many patches from
analog.com, so maybe there is a person who will help you, in case you do
not want to read submitting patches?

..

> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> + spi-max-frequency: true

Drop

> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vref-supply:
> + description:
> + ADC reference voltage supply
> +
> + start-gpios:
> + description:
> + Pin that controls start synchronization pulse.
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "adi,ad7779";

Messed indentation. Keep same for entire example, e.g.
Use 4 spaces for example indentation.

Best regards,
Krzysztof