Re: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion
From: Arnd Bergmann
Date: Fri May 31 2024 - 12:32:04 EST
On Fri, May 31, 2024, at 05:49, srinivas pandruvada wrote:
> On Wed, 2024-05-29 at 15:18 +0200, Arnd Bergmann wrote:
>> On Wed, May 29, 2024, at 09:05, Zhang, Lixu wrote:
>>
>> > >
>> > > for (i = 0; i < fragment->fragment_cnt && offset <
>> > > ish_fw->size; i++) {
>> > You added a parameter fragment_count, but you didn't use it. Did
>> > you
>> > intend to use it here?
>> >
>>
>> My mistake, that was again broken in my incorrect
>> rebase.
>>
> Do you have updated patch? Lixu can try and make sure that the
> functionality is not broken by changes.
>
I've sent v2 now, hopefully addressing all the issues
of the first version. I've dropped the other patch now,
though I still think something is wrong there.
Arnd