Re: [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW_HELPER

From: Kalle Valo
Date: Fri May 31 2024 - 14:53:42 EST


Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes:

> Make the driver use qcom_fw_helper to autodetect the path to the
> calibration data file.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Not a fan of one sentence commit messages. It would be nice to explain a
bit more in the commit message, for instance answering to the question
'why?' and maybe provide a short example how this is supposed to work?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches