Re: [net-next PATCH v2 2/2] net: phy: aquantia: add support for PHY LEDs

From: Andrew Lunn
Date: Fri May 31 2024 - 15:56:58 EST


> +#define AQR_MAX_LEDS 3

> +int aqr_phy_led_brightness_set(struct phy_device *phydev,
> + u8 index, enum led_brightness value)
> +{
> + if (index > 2)
> + return -EINVAL;

AQR_MAX_LEDS should be used here.

Apart from that:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

pw-bot: cr