Re: [PATCH] soc: qcom: icc-bwmon: Add tracepoints in bwmon_intr_thread

From: kernel test robot
Date: Fri May 31 2024 - 16:30:29 EST


Hi Shivnandan,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.10-rc1 next-20240531]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shivnandan-Kumar/soc-qcom-icc-bwmon-Add-tracepoints-in-bwmon_intr_thread/20240531-185658
base: linus/master
patch link: https://lore.kernel.org/r/20240531105404.879267-1-quic_kshivnan%40quicinc.com
patch subject: [PATCH] soc: qcom: icc-bwmon: Add tracepoints in bwmon_intr_thread
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20240601/202406010409.xiR31FVt-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240601/202406010409.xiR31FVt-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406010409.xiR31FVt-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

In file included from include/trace/trace_events.h:419,
from include/trace/define_trace.h:102,
from drivers/soc/qcom/trace_icc-bwmon.h:49,
from drivers/soc/qcom/icc-bwmon.c:21:
>> include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:39:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
39 | );
| ^~
In file included from include/trace/trace_events.h:375:
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h: In function 'trace_event_raw_event_qcom_bwmon_update':
>> include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:28:17: error: '__assign_str' undeclared (first use in this function)
28 | __assign_str(name, name);
| ^~~~~~~~~~~~
include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
402 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:13:1: note: in expansion of macro 'TRACE_EVENT'
13 | TRACE_EVENT(qcom_bwmon_update,
| ^~~~~~~~~~~
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:27:9: note: in expansion of macro 'TP_fast_assign'
27 | TP_fast_assign(
| ^~~~~~~~~~~~~~
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:28:17: note: each undeclared identifier is reported only once for each function it appears in
28 | __assign_str(name, name);
| ^~~~~~~~~~~~
include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
402 | { assign; } \
| ^~~~~~
include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
44 | PARAMS(assign), \
| ^~~~~~
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:13:1: note: in expansion of macro 'TRACE_EVENT'
13 | TRACE_EVENT(qcom_bwmon_update,
| ^~~~~~~~~~~
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:27:9: note: in expansion of macro 'TP_fast_assign'
27 | TP_fast_assign(
| ^~~~~~~~~~~~~~
In file included from include/trace/trace_events.h:469:
include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h: At top level:
>> include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h:39:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
39 | );
| ^~
include/trace/stages/stage6_event_callback.h:34: note: macro "__assign_str" defined here
34 | #define __assign_str(dst) \
|


vim +/__assign_str +39 include/trace/../../drivers/soc/qcom//trace_icc-bwmon.h

14
15 TP_PROTO(const char *name,
16 unsigned int meas_kbps, unsigned int up_kbps, unsigned int down_kbps),
17
18 TP_ARGS(name, meas_kbps, up_kbps, down_kbps),
19
20 TP_STRUCT__entry(
21 __string(name, name)
22 __field(unsigned int, meas_kbps)
23 __field(unsigned int, up_kbps)
24 __field(unsigned int, down_kbps)
25 ),
26
27 TP_fast_assign(
> 28 __assign_str(name, name);
29 __entry->meas_kbps = meas_kbps;
30 __entry->up_kbps = up_kbps;
31 __entry->down_kbps = down_kbps;
32 ),
33
34 TP_printk("name=%s meas_kbps=%u up_kbps=%u down_kbps=%u",
35 __get_str(name),
36 __entry->meas_kbps,
37 __entry->up_kbps,
38 __entry->down_kbps)
> 39 );
40

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki