Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835

From: Florian Fainelli
Date: Fri May 31 2024 - 17:36:38 EST

On 5/15/24 00:54, Conor Dooley wrote:
On Tue, May 14, 2024 at 09:20:06AM -0700, Florian Fainelli wrote:
On 5/14/24 05:29, Conor Dooley wrote:
On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
a number of essential services, including but not limited to a Linux
common clock framework provider. Make sure that enable
CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.

Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
---
drivers/mailbox/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 42940108a187..2b4cde562a90 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -109,6 +109,7 @@ config ALTERA_MBOX
config BCM2835_MBOX
tristate "BCM2835 Mailbox"
depends on ARCH_BCM2835
+ default ARCH_BCM2835

This is just "default y", since I doubt ARCH_BCM2835 can be a module?

Right, although I intend to also add COMPILE_TEST, by then, it might be
preferable to have it "default ARCH_BCM2835".

I'm not sure what COMPILE_TEST would have to do with the default,
the default shouldn't be important there, right?

Sorry for the late feedback, what I meant is that when you do enable COMPILE_TEST, you might not want everything to be defaulted to 'y' by default, but that can be fixed when I add COMPILE_TEST after this patch series land.
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature