Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add alert-polarity property

[Guenter Roeck]

On 5/31/24 00:41, Krzysztof Kozlowski wrote:
> On 29/05/2024 16:01, Guenter Roeck wrote:
> > On 5/29/24 00:07, Krzysztof Kozlowski wrote:
> > > On 29/05/2024 08:07, Amna Waseem wrote:
> > > > Add a property to the binding to configure the Alert Polarity.
> > > > Alert pin is asserted based on the value of Alert Polarity bit of
> > > > Mask/Enable register. It is by default 0 which means Alert pin is
> > > > configured to be active low. To configure it to active high, set
> > > > alert-polarity property value to 1.
> > > >
> > > > Signed-off-by: Amna Waseem <Amna.Waseem@xxxxxxxx>
> > > > ---
> > > >    Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 +++++++++
> > > >    1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> > > > index df86c2c92037..a3f0fd71fcc6 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> > > > @@ -66,6 +66,14 @@ properties:
> > > >        description: phandle to the regulator that provides the VS supply typically
> > > >          in range from 2.7 V to 5.5 V.
> > > >    
> > > > +  alert-polarity:
> > >
> > > Missing vendor prefix.
> >
> > Are you sure you want a vendor prefix here ? Reason for asking is that
> > many hardware monitoring chips have configurable alert or interrupt polarity,
> > only the name is different. Some examples are the JC42.4 standard ("event
> > polarity"), adt7410/adt7420 "interrupt polarity", MAX31827 ("alarm polarity"),
> > or DS1621 ("output polarity"). We even have a vendor property, "adi,alarm-pol",
> > used for MAX31827.
>
> Hm, I just checked if this is already existing property, but indeed I
> did not check other variants.
>
> Indeed it could go to common properties - hwmon-common.yaml. But then
> how about using strings (as I asked before...).

I can't really comment on the strings; that is out of my knowledge zone.
It might make sense to have hwmon-common.yaml, but I think that would
require a some (read: a lot of) work.

Guenter