Re: [PATCH] staging: r8712u: remove unused struct 'zero_bulkout_context'

[Philipp Hortmann]

On 5/29/24 02:08, linux@xxxxxxxxxxx wrote:

please remove the following line:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
To me it is not important which commit introduced the struct. This is 
not a bug. So I would omit this lines and use instead just:
Remove struct zero_bulkout_context as it is unused.
> 'zero_bulkout_context' is unused since the original
> commit 2865d42c78a9 ("staging: r8712u: Add the new driver to the
> mainline kernel").
please remove the following line:
> Remove it. >
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> ---
>   drivers/staging/rtl8712/usb_ops_linux.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
> index b2181e1e2d38..0a3451cdc8a1 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -26,13 +26,6 @@
>   #define	RTL871X_VENQT_READ	0xc0
>   #define	RTL871X_VENQT_WRITE	0x40
>   
> -struct zero_bulkout_context {
> -	void *pbuf;
> -	void *purb;
> -	void *pirp;
> -	void *padapter;
> -};
> -
>   uint r8712_usb_init_intf_priv(struct intf_priv *pintfpriv)
>   {
>   	pintfpriv->piorw_urb = usb_alloc_urb(0, GFP_ATOMIC);


Hi David,

I would prefer the following changes:
Subject: please change from r8712u which is the compiled driver name to 
folder name of the driver: rtl8712

Please also consider the above hints.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Please contact me for any questions.

Thanks for your support.

Bye Philipp