Re: [PATCH 3/7] MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT

From: Maciej W. Rozycki
Date: Sat Jun 01 2024 - 18:30:15 EST


On Sat, 11 May 2024, Jiaxun Yang wrote:

> csrc-r4k suffers from SMP synchronization overhead.
[...]
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index f1aa1bf11166..fa8ca0287568 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1083,6 +1083,7 @@ config CSRC_IOASIC
>
> config CSRC_R4K
> select CLOCKSOURCE_WATCHDOG if CPU_FREQ
> + select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT

Shouldn't it be:

select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT && SMP

then?

Maciej