Re: [PATCH] KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko

[Google]

On Sat, 1 Jun 2024 15:19:39 -0700
Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:

> make allmodconfig && make W=1 C=1 reports for lib/test_*.ko:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_user_copy.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> ---
[...]

> diff --git a/lib/test_kprobes.c b/lib/test_kprobes.c
> index 0648f7154f5c..e707f7b3a366 100644
> --- a/lib/test_kprobes.c
> +++ b/lib/test_kprobes.c
> @@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = {
>  
>  kunit_test_suites(&kprobes_test_suite);
>  
> +MODULE_DESCRIPTION("simple sanity test for *probes");

nit: Could you make it "simple sanity test for k*probes" ? because
there is test_fprobe.c.

Thank you,


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>