RE: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion

[Zhang, Lixu]

>-----Original Message-----
>From: Arnd Bergmann <arnd@xxxxxxxxxx>
>Sent: Saturday, June 1, 2024 12:28 AM
>To: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>; Jiri Kosina
><jikos@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>; Zhang, Lixu
><lixu.zhang@xxxxxxxxx>
>Cc: Arnd Bergmann <arnd@xxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx
>Subject: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
>
>@@ -228,23 +233,24 @@ void ishtp_loader_work(struct work_struct *work)
> 		return;
> 	}
>
>-	fragment->fragment.header.command =
>LOADER_CMD_XFER_FRAGMENT;
>-	fragment->fragment.xfer_mode = LOADER_XFER_MODE_DMA;
>-	fragment->fragment.is_last = 1;
>-	fragment->fragment.size = ish_fw->size;
>+	fragment->fragment.header = cpu_to_le32(fragment_hdr.val32);;
s/;;/;/

>+	fragment->fragment.xfer_mode =
>cpu_to_le32(LOADER_XFER_MODE_DMA);
>+	fragment->fragment.is_last = cpu_to_le32(1);
>+	fragment->fragment.size = cpu_to_le32(ish_fw->size);
> 	/* Calculate the size of a single DMA fragment */
> 	fragment_size = PFN_ALIGN(DIV_ROUND_UP(ish_fw->size,