RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline ipsec transmit offload

[Bharat Bhushan]

> -----Original Message-----
> From: Simon Horman <horms@xxxxxxxxxx>
> Sent: Saturday, June 1, 2024 3:50 PM
> To: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri
> Goutham <sgoutham@xxxxxxxxxxx>; Geethasowjanya Akula
> <gakula@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>;
> Hariprasad Kelam <hkelam@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; Jerin Jacob
> <jerinj@xxxxxxxxxxx>; Linu Cherian <lcherian@xxxxxxxxxxx>;
> richardcochran@xxxxxxxxx
> Subject: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline ipsec
> transmit offload
> 
> 
> ----------------------------------------------------------------------
> On Tue, May 28, 2024 at 07:23:47PM +0530, Bharat Bhushan wrote:
> > Prepare and submit crypto hardware (CPT) instruction for outbound
> > inline ipsec crypto mode offload. The CPT instruction have
> > authentication offset, IV offset and encapsulation offset in input
> > packet. Also provide SA context pointer which have details about algo,
> > keys, salt etc. Crypto hardware encrypt, authenticate and provide the
> > ESP packet to networking hardware.
> >
> > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> 
> Hi Bharat,
> 
> A minor nit from my side as it looks like there will be a v4 anyway.
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> 
> ...
> 
> > +bool cn10k_ipsec_transmit(struct otx2_nic *pf, struct netdev_queue *txq,
> > +			  struct otx2_snd_queue *sq, struct sk_buff *skb,
> > +			  int num_segs, int size)
> > +{
> 
> ...
> 
> > +	/* Check for valid SA context */
> > +	sa_info = (struct cpt_ctx_info_s *)x->xso.offload_handle;
> > +	if (!sa_info || !sa_info->sa_iova) {
> > +		netdev_err(pf->netdev, "Invalid SA conext\n");
> 
> nit: context
> 
>      checkpatch.pl --codespell is your friend.

Will fix here and run this on all patches.

Thanks
-Bharat

> 
> > +		goto drop;
> > +	}
> 
> ...