Re: [PATCH v3 1/4] arm: dts: nxp: lpc: lpc32xx: drop 'clocks' form rtc

From: Javier Carrasco
Date: Mon Jun 03 2024 - 06:24:57 EST


On 13/04/2024 22:22, Javier Carrasco wrote:
> The RTC does not provide a controllable clock signal (it uses a fixed
> 32768 Hz crystal, the input clock of the SoC). Remove the 'clocks'
> property to better describe the device and avoid errors when checking
> the dts against the nxp,lpc3220-rtc binding.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
> arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 974410918f35..f78d67e672b4 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -384,7 +384,6 @@ rtc: rtc@40024000 {
> reg = <0x40024000 0x1000>;
> interrupt-parent = <&sic1>;
> interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clk LPC32XX_CLK_RTC>;
> };
>
> gpio: gpio@40028000 {
>

A little reminder: the rest of the series was applied, but this patch is
still pending.The nxp,lpc3220-rtc binding was moved to trivial-rtc.yaml
and it is already in the mainline kernel.

Best regards,
Javier Carrasco