Re: [PATCH 1/1] i3c: master: svc: fix IBIWON not set if IBI follow a hot join
From: Miquel Raynal
Date: Mon Jun 03 2024 - 09:49:29 EST
Hi Frank,
Frank.Li@xxxxxxx wrote on Fri, 31 May 2024 11:43:08 -0400:
> When an In-Band Interrupt(IBI) occurs after svc_i3c_master_do_daa_locked(),
> typically triggered during a Hot Join (HJ) event, the IBIWON flag fails to
> be set when issuing an auto IBI command.
>
> The issue stems from the omission of emitting STOP upon successful
> execution of svc_i3c_master_do_daa_locked(). Consequently, the controller
> interprets it as a repeat start when emitting the auto IBI command. Per the
> I3C specification, an IBI should never occur during a repeat start, thus
> preventing the IBIWON flag from being set.
>
> Emit STOP regardless of the success or failure of
> svc_i3c_master_do_daa_locked() to match I3C spec requirement.
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
There was no hot-join support in this commit. You can probably use
instead:
Fixes: 05b26c31a485 ("i3c: master: svc: add hot join support")
Thanks,
Miquèl