Re: [PATCH RFT v3 3/4] hwmon: (spd5118) Add suspend/resume support

[Guenter Roeck]

On 6/3/24 05:31, Stephen Horvath wrote:
> Hi,
>
> On 1/6/24 09:05, Guenter Roeck wrote:
> > Add suspend/resume support to ensure that limit and configuration
> > registers are updated and synchronized after a suspend/resume cycle.
> >
> > Cc: Armin Wolf <W_Armin@xxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > v3: No change
> >
> > v2: New patch
> >
> > RFT: I tested the patch through a suspend/resume cycle, and it seems
> >       to work, but I am not sure if that had any effect because,
> >       after all, the memory is still active during suspend/resume.
> >       I was unable to test a hibernation cycle with my system.
>
> For me, the driver just reports 0°C after suspend/resume, but works fine beforehand, tested on both my desktop and laptop, with kernel 6.9.3 and 6.10.0-rc2 (on the laptop only).
>
> Hibernation does seem to work fine though (at least on 6.9.3).

Thanks a lot for the report. I can confirm that this happens if the enable
attribute was not touched before the suspend/resume cycle. I'll send another
version with the fix.

Guenter