Re: [PATCH] dt-bindings: nvmem: Use soc-nvmem node name instead of nvmem

From: Rob Herring
Date: Mon Jun 03 2024 - 10:52:12 EST


On Mon, May 27, 2024 at 10:53:50AM +0200, Michal Simek wrote:
> Based on commit d8764d347bd7 ("dt-bindings: firmware: xilinx: Describe
> soc-nvmem subnode") soc-nvmem should be used instead of simple nvmem that's
> why also update example to have it described correctly everywhere.
>
> Fixes: a0cfd5e99782 ("dt-bindings: nvmem: Convert xlnx,zynqmp-nvmem.txt to yaml")
> Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
> ---
>
> Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml b/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml
> index 917c40d5c382..1cbe44ab23b1 100644
> --- a/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml
> @@ -28,7 +28,7 @@ unevaluatedProperties: false
>
> examples:
> - |
> - nvmem {
> + soc-nvmem {

This doesn't seem like an improvement. Is there another nvmem node at
this level? I would fix the binding instead if not.

> compatible = "xlnx,zynqmp-nvmem-fw";
> nvmem-layout {
> compatible = "fixed-layout";
> --
> 2.40.1
>