Re: [PATCH v2 3/5] platform/chrome: cros_ec_lpc: Add a new quirk for ACPI id

[Mario Limonciello]

On 6/3/2024 04:30, Tzung-Bi Shih wrote:
> On Mon, Jun 03, 2024 at 07:38:32AM +0100, Ben Walsh wrote:
> > @@ -436,6 +463,8 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
> >   
> >   	ec_lpc->mmio_memory_base = EC_LPC_ADDR_MEMMAP;
> >   
> > +	adev = ACPI_COMPANION(dev);
> > +
>
> The change is irrelevant to the patch.

It looks relevant to me.  The companion needs to get set before the 
quirk overwrites it.

> > @@ -538,7 +577,6 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
> >   	 * Connect a notify handler to process MKBP messages if we have a
> >   	 * companion ACPI device.
> >   	 */
> > -	adev = ACPI_COMPANION(dev);
> >   	if (adev) {
> >   		status = acpi_install_notify_handler(adev->handle,
> >   						     ACPI_ALL_NOTIFY,
>
> See above comment.