Re: [PATCH v2 2/3] iio: light: ROHM BH1745 colour sensor

From: Ivan Orlov
Date: Mon Jun 03 2024 - 12:49:20 EST


On 6/3/24 17:21, Mudit Sharma wrote:
Add support for BH1745, which is an I2C colour sensor with red, green,
blue and clear channels. It has a programmable active low interrupt pin.
Interrupt occurs when the signal from the selected interrupt source
channel crosses set interrupt threshold high or low level.

This driver includes device attributes to configure the following:
- Interrupt pin latch: The interrupt pin can be configured to
be latched (until interrupt register (0x60) is read or initialized)
or update after each measurement.
- Interrupt source: The colour channel that will cause the interrupt
when channel will cross the set threshold high or low level.

This driver also includes device attributes to present valid
configuration options/values for:
- Integration time
- Interrupt colour source
- Hardware gain

Signed-off-by: Mudit Sharma <muditsharma.info@xxxxxxxxx>
---

LGTM,

Reviewed-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>

--
Kind regards,
Ivan Orlov