Re: [PATCH] null_blk: fix validation of block size

From: Bart Van Assche
Date: Mon Jun 03 2024 - 13:04:37 EST

Next message: Shree Ramamoorthy: "[PATCH v1 0/1] regulator: tps6594-regulator: Correct nr_types assignment"
Previous message: Steven Rostedt: "Re: [PATCH v2 10/27] ftrace: Add subops logic to allow one ops to manage many"
In reply to: Andreas Hindborg: "Re: [PATCH] null_blk: fix validation of block size"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 6/1/24 13:23, Andreas Hindborg wrote:

+ ((dev->blocksize & (dev->blocksize - 1)) != 0)) {

Please use is_power_of_2() instead of open-coding it.

Bart.

Next message: Shree Ramamoorthy: "[PATCH v1 0/1] regulator: tps6594-regulator: Correct nr_types assignment"
Previous message: Steven Rostedt: "Re: [PATCH v2 10/27] ftrace: Add subops logic to allow one ops to manage many"
In reply to: Andreas Hindborg: "Re: [PATCH] null_blk: fix validation of block size"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]