Re: [PATCH] mm/memory_hotplug: prevent accessing by index=-1

From: David Hildenbrand
Date: Mon Jun 03 2024 - 13:58:27 EST


On 03.06.24 19:53, Oscar Salvador wrote:
On Mon, Jun 03, 2024 at 06:07:39PM +0200, David Hildenbrand wrote:
pgdat is never dereferenced when "nid == NUMA_NO_NODE".

Right.

NODE_DATA is defined as

arch/arm64/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)])
arch/loongarch/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)])
arch/mips/include/asm/mach-ip27/mmzone.h:#define NODE_DATA(n) (&__node_data[(n)]->pglist)

All look fine, but mips.

$ git grep MEMORY_HOTPLUG | grep mips | wc -l
0

I think it owuld be problematic, if mips would support memory hotplug.

Or am I missing something?

--
Cheers,

David / dhildenb