Re: [PATCH] sysfs: Add stub sysfs_bin_attr_simple_read() for !CONFIG_SYSFS

[Jason Gunthorpe]

On Mon, Jun 03, 2024 at 10:46:34PM +0200, Lukas Wunner wrote:
> On Mon, Jun 03, 2024 at 02:30:45PM -0300, Jason Gunthorpe wrote:
> > Since the only declaration for sysfs_bin_attr_simple_read() is inside the
> > "#ifdef CONFIG_SYSFS". Add a stub to the #else section too.
> [...]
> > I don't see a patch for this yet, but I did find a 0-day robot complaint:
> > 
> > https://lore.kernel.org/all/202404200345.eGdn5uxW-lkp@xxxxxxxxx/
> 
> I already submitted a patch on May 23, but it hasn't been applied yet:
> 
> https://lore.kernel.org/all/05f4290439a58730738a15b0c99cd8576c4aa0d9.1716461752.git.lukas@xxxxxxxxx/

Ah, it is not a good practice to put patches you want applied buried
in a thread, that is perhaps why it has been overlooked..

> (My patch returns 0, yours -EINVAL, but I don't think that matters.)

Yes, it looks like the function will never be called.

Jason