Re: [PATCH v20 01/12] block: Introduce queue limits and sysfs for copy-offload support

From: Christoph Hellwig
Date: Tue Jun 04 2024 - 00:32:01 EST


On Mon, Jun 03, 2024 at 06:43:56AM +0000, Nitesh Shetty wrote:
>> Also most block limits are in kb. Not that I really know why we are
>> doing that, but is there a good reason to deviate from that scheme?
>>
> We followed discard as a reference, but we can move to kb, if that helps
> with overall readability.

I'm not really sure what is better. Does anyone remember why we did
the _kb version? Either way some amount of consistency would be nice.