Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

From: Heiko Stübner
Date: Tue Jun 04 2024 - 03:28:25 EST


Am Sonntag, 2. Juni 2024, 17:57:12 CEST schrieb Andy Shevchenko:
> Make two APIs look similar. Hence convert match_string() to be
> a 2-argument macro. In order to avoid unneeded churn, convert
> all users as well. There is no functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>
> Compile tested with `make allyesconfig` and `make allmodconfig`
> on x86_64, arm, aarch64, powerpc64 (8 builds total).
>
> I guess the best is to apply it to Linus' tree directly.
> And now it seems a good timing as there are no new users
> of this API either in v6.10-rcX, or in Linux Next.
>
> But if you think differently, tell me.
>

For the Rockchip clock part

> drivers/clk/rockchip/clk.c | 4 +--

[...]

> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index 73d2cbdc716b..30414d081f46 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -266,8 +266,8 @@ static struct clk *rockchip_clk_register_frac_branch(
> struct clk *mux_clk;
> int ret;
>
> - frac->mux_frac_idx = match_string(child->parent_names,
> - child->num_parents, name);
> + frac->mux_frac_idx = __match_string(child->parent_names,
> + child->num_parents, name);
> frac->mux_ops = &clk_mux_ops;
> frac->clk_nb.notifier_call = rockchip_clk_frac_notifier_cb;
>

Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>