Re: [PATCH v3 10/11] ARM: dts: stm32: add ethernet1 for STM32MP135F-DK board

[Christophe ROULLIER]

On 6/3/24 15:08, Marek Vasut wrote:
> On 6/3/24 11:27 AM, Christophe Roullier wrote:
> > Ethernet1: RMII with crystal
> > PHY used is SMSC (LAN8742A)
> >
> > Signed-off-by: Christophe Roullier <christophe.roullier@xxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/st/stm32mp135f-dk.dts | 24 ++++++++++++++++++++++++
> >   1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts 
> > b/arch/arm/boot/dts/st/stm32mp135f-dk.dts
> > index 567e53ad285fa..cebe9b91eced9 100644
> > --- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts
> > +++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts
> > @@ -19,6 +19,7 @@ / {
> >       compatible = "st,stm32mp135f-dk", "st,stm32mp135";
> >         aliases {
> > +        ethernet0 = &ethernet1;
> >           serial0 = &uart4;
> >           serial1 = &usart1;
> >           serial2 = &uart8;
> > @@ -141,6 +142,29 @@ &cryp {
> >       status = "okay";
> >   };
> >   +&ethernet1 {
> > +    status = "okay";
> > +    pinctrl-0 = <&eth1_rmii_pins_a>;
> > +    pinctrl-1 = <&eth1_rmii_sleep_pins_a>;
> > +    pinctrl-names = "default", "sleep";
> > +    phy-mode = "rmii";
> > +    max-speed = <100>;
>
> Is this needed ? RMII cannot go faster than 100 .
ok (I will put in v4)
> Also, keep the list sorted alphabetically , P goes after M .
ok (I will put in v4)
> > +    phy-handle = <&phy0_eth1>;
> > +
> > +    mdio {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        compatible = "snps,dwmac-mdio";
> > +
> > +        phy0_eth1: ethernet-phy@0 {
> > +            compatible = "ethernet-phy-id0007.c131";
> > +            reset-gpios =  <&mcp23017 9 GPIO_ACTIVE_LOW>;
>
> Extra space between = and < , please drop.
ok (I will put in v4)