Re: [PATCH] [v3] HID: intel-ish-hid: fix endian-conversion

From: srinivas pandruvada
Date: Tue Jun 04 2024 - 07:23:32 EST


On Mon, 2024-06-03 at 08:38 +0000, Zhang, Lixu wrote:
> > -----Original Message-----
> > From: Arnd Bergmann <arnd@xxxxxxxxxx>
> > Sent: Monday, June 3, 2024 3:41 PM
> > To: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>; Jiri
> > Kosina
> > <jikos@xxxxxxxxxx>; Zhang, Lixu <lixu.zhang@xxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>; Benjamin Tissoires
> > <bentiss@xxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Subject: [PATCH] [v3] HID: intel-ish-hid: fix endian-conversion
> >
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > The newly added file causes a ton of sparse warnings about the
> > incorrect use of
> > __le32 and similar types:
> >
> > Add the necessary conversions and use temporary variables where
> > appropriate
> > to avoid converting back.
> >
> > Fixes: 579a267e4617 ("HID: intel-ish-hid: Implement loading
> > firmware from
> > host feature")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Reviewed-by: Zhang Lixu <lixu.zhang@xxxxxxxxx>
> Tested-by: Zhang Lixu <lixu.zhang@xxxxxxxxx>

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>

>
> Thanks,
> Lixu
> > ---