Re: [PATCH 2/2] serial: sc16is7xx: re-add Kconfig SPI or I2C dependency

[Hugo Villeneuve]

On Tue, 4 Jun 2024 09:09:12 +0200
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> Hi Hugo,
> 
> On Mon, Jun 3, 2024 at 5:26 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> >
> > Commit d49216438139
> > ("serial: sc16is7xx: split into core and I2C/SPI parts (core)")
> > removed Kconfig SPI_MASTER or I2C dependency for SERIAL_SC16IS7XX (core).
> > This removal was done because I inadvertently misinterpreted some review
> > comments.
> >
> > Because of that, the driver question now pops up if both I2C and
> > SPI_MASTER are disabled.
> >
> > Re-add Kconfig SPI_MASTER or I2C dependency to fix the problem.
> >
> > Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Fixes: d49216438139 ("serial: sc16is7xx: split into core and I2C/SPI parts (core)")
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1025,6 +1025,7 @@ config SERIAL_SCCNXP_CONSOLE
> >
> >  config SERIAL_SC16IS7XX
> >         tristate "NXP SC16IS7xx UART support"
> > +       depends on SPI_MASTER || I2C
> 
> You may want to add "|| COMPILE_TEST".

Hi Geert,
I will add this to my TODO list, since this patch series is already in Greg's tty tree.

Hugo

> 
> >         select SERIAL_CORE
> >         select SERIAL_SC16IS7XX_SPI if SPI_MASTER
> >         select SERIAL_SC16IS7XX_I2C if I2C
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 


-- 
Hugo Villeneuve <hugo@xxxxxxxxxxx>