Re: [PATCH] block: fix request.queuelist usage in flush

From: Jens Axboe
Date: Tue Jun 04 2024 - 10:17:30 EST



On Tue, 04 Jun 2024 14:47:45 +0800, Chengming Zhou wrote:
> Friedrich Weber reported a kernel crash problem and bisected to commit
> 81ada09cc25e ("blk-flush: reuse rq queuelist in flush state machine").
>
> The root cause is that we use "list_move_tail(&rq->queuelist, pending)"
> in the PREFLUSH/POSTFLUSH sequences. But rq->queuelist.next == xxx since
> it's popped out from plug->cached_rq in __blk_mq_alloc_requests_batch().
> We don't initialize its queuelist just for this first request, although
> the queuelist of all later popped requests will be initialized.
>
> [...]

Applied, thanks!

[1/1] block: fix request.queuelist usage in flush
commit: a315b96155e4c0362742aa3c3b3aebe2ec3844bd

Best regards,
--
Jens Axboe