Re: [PATCH net-next v1] netfilter: cttimeout: remove 'l3num' attr check

From: Simon Horman
Date: Tue Jun 04 2024 - 12:48:45 EST


On Fri, May 31, 2024 at 09:28:47AM +0800, Lin Ma wrote:
> After commit dd2934a95701 ("netfilter: conntrack: remove l3->l4 mapping
> information"), the attribute of type `CTA_TIMEOUT_L3PROTO` is not used
> any more in function cttimeout_default_set.
>
> However, the previous commit ea9cf2a55a7b ("netfilter: cttimeout: remove
> set but not used variable 'l3num'") forgot to remove the attribute
> present check when removing the related variable.
>
> This commit removes that check to ensure consistency.
>
> Signed-off-by: Lin Ma <linma@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>