Re: [PATCH v5 2/9] dt-bindings: adc: ad7173: add support for ad411x

[Conor Dooley]

On Mon, Jun 03, 2024 at 07:23:00PM +0300, Dumitru Ceclan via B4 Relay wrote:
> +      common-mode-channel:
> +        description:
> +          This property is used for defining the negative input of a
> +          single-ended or pseudo-differential voltage channel.
> +
> +          Special inputs are valid as well.
> +        minimum: 0
> +        maximum: 31

I think this property, since it purports to be a common one due to the
lack of a vendor prefix, should be documented in adc.yaml.

> +
>        adi,reference-select:
>          description: |
>            Select the reference source to use when converting on
> @@ -154,9 +213,31 @@ patternProperties:
>            - avdd
>          default: refout-avss
>  
> +      adi,current-channel:
> +        description: |
> +          Signal that the selected inputs are current channels.
> +          Only available on AD4111 and AD4112.

> +        type: boolean
Instead of boolean, use:
    $ref: /schemas/types.yaml#/definitions/flag

Otherwise, I think this all looks okay.

Attachment: signature.asc
Description: PGP signature