Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

[Dr. David Alan Gilbert]

* Simon Horman (horms@xxxxxxxxxx) wrote:
> On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > 
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
> 
> nit: Maybe commit lines are best not line-wrapped.
>      I'm unsure.

Yeh I wasn't too sure, checkpatch seems to have code
to deal with it, so it is expecting it could be wrapped:

  # A commit match can span multiple lines so this block attempts to find a
  # complete typical commit on a maximum of 3 lines

> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> 
> The above not withstanding, this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

Thanks!

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/