Re: [PATCH v2] wifi: mac80211: Avoid address calculations via out of bounds array indexing

From: Kenton Groombridge
Date: Tue Jun 04 2024 - 14:54:15 EST


On 24/05/29 04:54PM, Johannes Berg wrote:
> On Fri, 2024-05-17 at 10:54 -0400, Kenton Groombridge wrote:
> > req->n_channels must be set before req->channels[] can be used.
> >
>
> I don't know why, but this patch breaks a number of hwsim test cases.
>
> https://w1.fi/cgit/hostap/tree/tests/hwsim/
>
> johannes

Pardon my absence.

I'm also not sure why these tests are failing. Unless I'm missing
something, the runtime behavior of these code paths shouldn't have
changed significantly.

FWIW, I have been running this patch on real hardware and connecting to
Wi-Fi networks with it for the past couple weeks without problems.
Though, I see that these tests are probably testing Wi-Fi modes that I
am not using.

--
Kenton Groombridge
Gentoo Linux Developer, SELinux Project

Attachment: signature.asc
Description: PGP signature