Re: [PATCH memory-model 3/3] tools/memory-model: Add KCSAN LF mentorship session citation

From: Paul E. McKenney
Date: Wed Jun 05 2024 - 00:02:10 EST


On Wed, Jun 05, 2024 at 10:57:27AM +0900, Akira Yokosawa wrote:
> On Tue, 4 Jun 2024 15:14:19 -0700, Paul E. McKenney wrote:
> > Add a citation to Marco's LF mentorship session presentation entitled
> > "The Kernel Concurrency Sanitizer"
> >
> > [ paulmck: Apply Marco Elver feedback. ]
> >
> > Reported-by: Marco Elver <elver@xxxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Cc: Andrea Parri <parri.andrea@xxxxxxxxx>
> > Cc: Will Deacon <will@xxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Boqun Feng <boqun.feng@xxxxxxxxx>
> > Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
> > Cc: David Howells <dhowells@xxxxxxxxxx>
> > Cc: Jade Alglave <j.alglave@xxxxxxxxx>
> > Cc: Luc Maranget <luc.maranget@xxxxxxxx>
> > Cc: Akira Yokosawa <akiyks@xxxxxxxxx>
>
> Paul,
>
> While reviewing this, I noticed that
> tools/memory-model/Documentation/README has no mention of
> access-marking.txt.
>
> It has no mention of glossary.txt or locking.txt, either.
>
> I'm not sure where are the right places in README for them.
> Can you update it in a follow-up change?
>
> Anyway, for this change,
>
> Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx>

Thank you, and good catch! Does the patch below look appropriate?

Thanx, Paul

------------------------------------------------------------------------

commit 834b22ba762fb59024843a64554d38409aaa82ec
Author: Paul E. McKenney <paulmck@xxxxxxxxxx>
Date: Tue Jun 4 20:59:35 2024 -0700

tools/memory-model: Add access-marking.txt to README

Given that access-marking.txt exists, this commit makes it easier to find.

Reported-by: Akira Yokosawa <akiyks@xxxxxxxxx>
Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>

diff --git a/tools/memory-model/Documentation/README b/tools/memory-model/Documentation/README
index db90a26dbdf40..304162743a5b8 100644
--- a/tools/memory-model/Documentation/README
+++ b/tools/memory-model/Documentation/README
@@ -47,6 +47,10 @@ DESCRIPTION OF FILES
README
This file.

+access-marking.txt
+ Guidelines for marking intentionally concurrent accesses to
+ shared memory.
+
cheatsheet.txt
Quick-reference guide to the Linux-kernel memory model.