Re: [PATCH v2 2/2] drm/panfrost: Add support for Mali on the MT8188 SoC

[Chen-Yu Tsai]

On Tue, Jun 4, 2024 at 8:39 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
>
> MediaTek MT8188 has a Mali-G57 MC3 (Valhall-JM): add a new
> compatible and platform data using the same supplies and the
> same power domain lists as MT8183 (one regulator, three power
> domains).
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index ef9f6c0716d5..4e2d9f671a0d 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -777,6 +777,14 @@ static const struct panfrost_compatible mediatek_mt8186_data = {
>         .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
>  };
>
> +static const struct panfrost_compatible mediatek_mt8188_data = {
> +       .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1,
> +       .supply_names = mediatek_mt8183_b_supplies,
> +       .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains),
> +       .pm_domain_names = mediatek_mt8183_pm_domains,
> +       .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
> +};
> +
>  static const char * const mediatek_mt8192_supplies[] = { "mali", NULL };
>  static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2",
>                                                            "core3", "core4" };
> @@ -808,6 +816,7 @@ static const struct of_device_id dt_match[] = {
>         { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data },
>         { .compatible = "mediatek,mt8183b-mali", .data = &mediatek_mt8183_b_data },
>         { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data },
> +       { .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
>         { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
>         {}
>  };
> --
> 2.45.1
>
>