Re: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o in TI_ICSSG_PRUETH_SR1

[Thorsten Leemhuis]

On 05.06.24 05:56, MD Danish Anwar wrote:
> icssg_config.c uses some APIs that are defined in icssg_queue.c.
> TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
> result the below build error is seen
> 
> ERROR: modpost: "icssg_queue_pop"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> ERROR: modpost: "icssg_queue_push"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> 
> Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202405182038.ncf1mL7Z-lkp@xxxxxxxxx/
> Fixes: 487f7323f39a ("net: ti: icssg-prueth: Add helper functions to configure FDB")
> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>
> ---
> Cc: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>

Thx, seems this did the trick (tested this patch with today's -next and
assuming here that no change fixed it in between).

Reported-and-tested-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
Closes:
https://lore.kernel.org/all/de980a49-b802-417a-a57e-2c47f67b08e4@xxxxxxxxxxxxx/

Ciao, Thorsten