Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data

[AngeloGioacchino Del Regno]

Il 04/06/24 18:33, Nicolas Pitre ha scritto:
> On Tue, 4 Jun 2024, AngeloGioacchino Del Regno wrote:
>
> > Il 03/06/24 14:06, Julien Panis ha scritto:
> > > This patch prevents from registering thermal entries and letting the
> > > driver misbehave if efuse data is invalid. A device is not properly
> > > calibrated if the golden temperature is zero.
> > >
> > > Signed-off-by: Julien Panis <jpanis@xxxxxxxxxxxx>
> >
> > Fixes tag, please.
>
> What should it refer to? This is arguably a robustness enhancement for a
> defficiency that has been there all along.

If that's been there since day 1, the fixes tag should be the day 1 commit,
of course.

I see that as an important bugfix and not just a robustness enhancement, as
SoCs with uncalibrated LVTS would *not work*, as the kernel would shut down
the system before even loading the userspace.

Regards,
Angelo