Re: [PATCH 6/6] KVM: PPC: Book3S HV: Add one-reg interface for HASHKEYR register

[Shivaprasad G Bhat]

On 6/4/24 11:37, Nicholas Piggin wrote:
> On Mon Jun 3, 2024 at 9:15 PM AEST, Shivaprasad G Bhat wrote:
> > The patch adds a one-reg register identifier which can be used to
> > read and set the virtual HASHKEYR for the guest during enter/exit
> > with KVM_REG_PPC_HASHKEYR. The specific SPR KVM API documentation
> > too updated.
> >
> > Signed-off-by: Shivaprasad G Bhat <sbhat@xxxxxxxxxxxxx>
> > ---
> >   Documentation/virt/kvm/api.rst            |    1 +
> >   arch/powerpc/include/uapi/asm/kvm.h       |    1 +
> >   arch/powerpc/kvm/book3s_hv.c              |    6 ++++++
> >   tools/arch/powerpc/include/uapi/asm/kvm.h |    1 +
> >   4 files changed, 9 insertions(+)
> >
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index 81077c654281..0c22cb4196d8 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -2439,6 +2439,7 @@ registers, find a list below:
> >     PPC     KVM_REG_PPC_PSSCR               64
> >     PPC     KVM_REG_PPC_DEC_EXPIRY          64
> >     PPC     KVM_REG_PPC_PTCR                64
> > +  PPC     KVM_REG_PPC_HASHKEYR            64
> Just looking at the QEMU side of this change made me think... AFAIKS
> we need to also set and get and migrate the HASHPKEY SPR.

Thanks Nick. I have posted the v2 with changes for HASHPKEYR

and your other suggestions at

171759276071.1480.9356137231993600304.stgit@xxxxxxxxxxxxx


Regards,

Shivaprasad

> The hashst/hashchk test cases might be "working" by chance if the SPR
> is always zero :/
>
> Thanks,
> Nick