Re: [PATCH 3/4] KVM: arm64: Fix FFR offset calculation for pKVM host state save and restore

From: Mark Brown
Date: Wed Jun 05 2024 - 09:39:29 EST


On Wed, Jun 05, 2024 at 01:12:34PM +0100, Fuad Tabba wrote:

> If my understanding of the spec is correct (which more often than not
> it isn't), I don't think we have an issue as long as we use the same
> value in the offset on saving/restoring, and that that value
> represents the maximum possible value.

Yes, we could also correct the issue by switching to use the system
enumerated maximum but that still leaves us setting one value and then
immediately assuming a different value. Reading the actual VL from the
hardware makes the code more obviously self consistent.

Attachment: signature.asc
Description: PGP signature