Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property

From: Rob Herring
Date: Wed Jun 05 2024 - 11:41:24 EST


On Wed, Jun 05, 2024 at 03:54:57PM +0530, Vineeth Karumanchi wrote:
> WOL modes such as magic-packet should be an OS policy.
> By default, advertise supported modes and use ethtool to activate
> the required mode.
>
> Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@xxxxxxx>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> 1 file changed, 1 insertion(+)

You forgot Krzysztof's ack.

>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 2c71e2cf3a2f..3c30dd23cd4e 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -146,6 +146,7 @@ patternProperties:
>
> magic-packet:
> type: boolean
> + deprecated: true
> description:
> Indicates that the hardware supports waking up via magic packet.
>
> --
> 2.34.1
>